scripts/build: improve whitespace / empty parameter handling in syscall scripts #87633
Conversation
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
|
Hello @lonkaars, and thank you very much for your first pull request to the Zephyr project! |
|
@lonkaars thanks for this. This can help to see of we can make a test-case / update existing test case to ensure the problem is indeed fixed as well as ensureing there are no side-effects. |
|
I'm currently working in a private repository so I can't share the original code that this fix is for. I've created a twister test case in my (local) Zephyr fork clone with the following function signature, which fails in the same way: __syscall void
test(int foo);Should I add While making the test case I also found |
I was assuming so.
would be nice to have as part of this PR.
Making it part of this PR is fine. |
|
Looking over the commit history on |
lonkaars
changed the title
parse_syscalls.py
Syscall regex matches may include whitespace characters other than space (i.e. `\n` or `\t`), which causes `gen_syscalls.py` to fail. This mainly affects long system call signatures wrapped onto multiple lines (e.g. by code formatter). This change replaces all successive whitespace in the regex match groups with a single space. Signed-off-by: Loek Le Blansch <loek.le-blansch.pv@renesas.com>
|
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
This commit adds a test for whitespace in syscall declaration function signatures. Signed-off-by: Loek Le Blansch <loek.le-blansch.pv@renesas.com>
This reverts commit 1993ea0 because the `parse_syscalls.py` script has been modified to not output whitespace characters other than spaces in the generated JSON file. Signed-off-by: Loek Le Blansch <loek.le-blansch.pv@renesas.com>
|
Syscall regex matches may include whitespace characters other than space (i.e.
\nor\t), which causesgen_syscalls.pyto fail. This mainly affects long system call signatures wrapped onto multiple lines (e.g. by code formatter). This change replaces all successive whitespace in the regex match groups with a single space.